• 
      

    Fix typing issues in the configforms JavaScript code.

    Review Request #13216 — Created Aug. 14, 2023 and submitted

    Information

    Djblets
    release-4.x

    Reviewers

    This updates the configforms typing code and unit tests to fix some
    typing issues that were encountered. These consisted of missing imports,
    undeclared member variables/attributes, model attributes that weren't
    marked as optional, and undeclared prototype attributes.

    There's also a fix to tsconfig.json, which was causing Backbone
    types to fail to be looked up. We now use the same setting that we have
    in Review Board.

    There were also some legacy String.strip() calls (which Djblets injects)
    that have been converted to native String.trim() calls.

    Verified that no typing issues remained.

    All unit tests pass.

    Summary ID
    Fix typing issues in the configforms JavaScript code.
    This updates the configforms typing code and unit tests to fix some typing issues that were encountered. These were mostly missing imports, undeclared member variables/attributes, and model attributes that weren't marked as optional. There's also a fix to `tsconfig.json`, which was causing `Backbone` types to fail to be looked up. We now use the same setting that we have in Review Board.
    c851fc1dd49910a0d591fe88ef5edbe236825c51
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (bc2aca3)