flake8
passed.
JSHint
passed.
Review Request #13216 — Created Aug. 14, 2023 and submitted
This updates the configforms typing code and unit tests to fix some
typing issues that were encountered. These consisted of missing imports,
undeclared member variables/attributes, model attributes that weren't
marked as optional, and undeclared prototype attributes.There's also a fix to
tsconfig.json
, which was causingBackbone
types to fail to be looked up. We now use the same setting that we have
in Review Board.There were also some legacy
String.strip()
calls (which Djblets injects)
that have been converted to nativeString.trim()
calls.
Verified that no typing issues remained.
All unit tests pass.
Summary | ID |
---|---|
c851fc1dd49910a0d591fe88ef5edbe236825c51 |