Fix a regression in updating configforms ListItem actions.

Review Request #13215 — Created Aug. 14, 2023 and submitted — Latest diff uploaded

Information

Djblets
release-4.x

Reviewers

When the configforms code was converted to Spina, ListItemView's
render() was changed to onInitialRender(). This prevented it from
being able to re-render when actions were changed. This has now been
converted to an onRender().

Similarly, ListView was also meant to be able to be re-rendered
(though doesn't have an immediate failure case we've hit). It's been
converted back to onRender() as well.

Unit tests passed.

Reproduced the problem I encounered where list item action updates
weren't being re-rendered.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix a regression in updating configforms ListItem actions.
When the configforms code was converted to Spina, `ListItemView`'s `render()` was changed to `onInitialRender()`. This prevented it from being able to re-render when actions were changed. This has now been converted to an `onRender()`. Similarly, `ListView` was also meant to be able to be re-rendered (though doesn't have an immediate failure case we've hit). It's been converted back to `onRender()` as well.
0aacb06e7ba288c2749f716aa1d2dfc1be218541 Christian Hammond
djblets/static/djblets/js/configForms/views/listItemView.ts
djblets/static/djblets/js/configForms/views/listView.ts
djblets/static/djblets/js/configForms/views/tests/listItemViewTests.ts
djblets/static/djblets/js/configForms/views/tests/listViewTests.ts
Loading...