Make a bunch of improvements to the tips in the review dialog.

 






 

 


  Review Request #13192
  —
  Created Aug. 8, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change makes a bunch of improvements to the new tips feature in the

review dialog:


    

  • Adds a hide button to allow people to hide the tips. While it's
    
  probably good for new users, experienced users likely won't want it
    
  cluttering up their screen. The preference for this is stored in a
    
  cookie
    • 

  • Moves the tips box to the top of the review dialog.
    • 

  • Changes it so the tips box is always visible, even when there's review
    
  content.
    • 

  • Adds new content to the tips list (thanks Michelle!).
    • 


 








  


 
 

  
    

  • Toggled the tips view back and forth.
    • 

  • Checked that the tips view shows up in the right place.
    • 

  • Verified that the initial tips view visibility respects the stored
    
  preference.
    • 

  • Ran unit tests.
    • 

  • Ran js-tests.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Make review dialog tips hide-able.
     
The new tips alert on the review dialog is intended to make things
easier for first-time users, but might be annoying for people who have
been using Review Board forever. It's already pretty unobtrusive,
because it only shows up when the review dialog is empty, but it's still
visual noise that people might not want to have.

This change adds a toggle that lets users hide it. The preference for
that is stored in a cookie, much the same way as the extra whitespace
for diffs.

Testing Done:
- Toggled the tips view back and forth.
- Verified that nothing appears when there's content in the review.
- Ran unit tests.
- Ran js-tests.

    

   
  		
  992315c431adcfdb81985f933726313a27930438
  David Trowbridge
 


 
  
 
 
  
   
    

     Make a bunch of improvements to the tips in the review dialog.
     
This change makes a bunch of improvements to the new tips feature in the
review dialog:
- Adds a hide button to allow people to hide the tips. While it's
  probably good for new users, experienced users likely won't want it
  cluttering up their screen. The preference for this is stored in a
  cookie
- Moves the tips box to the top of the review dialog.
- Changes it so the tips box is always visible, even when there's review
  content.
- Adds new content to the tips list (thanks Michelle!).

Testing Done:
- Toggled the tips view back and forth.
- Checked that the tips view shows up in the right place.
- Verified that the initial tips view visibility respects the stored
  preference.
- Ran unit tests.
- Ran js-tests.

    

   
  		
  5d725dabc3350f4920efe9008147e86a930aa55d
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/css/pages/reviews.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewDialogView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...