Fix up import paths and groups in new TypeScript code.

Review Request #13171 — Created Aug. 1, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

As we've defined how our JS codebase is going to work going forward,
we've not been terribly disciplined about how we do imports. This change
makes everything consistent with three import groups (3rd party, other
modules, and the current module) that kind of matches the way that our
Python code works. Where we can, this has been simplified to import
everything from the top-level indexes, which makes sorting things
alphabetically by module name much easier.

Ran js-tests.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Fix up import paths and groups in new TypeScript code.
As we've defined how our JS codebase is going to work going forward, we've not been terribly disciplined about how we do imports. This change makes everything consistent with three import groups (3rd party, other modules, and the current module) that kind of matches the way that our Python code works. Where we can, this has been simplified to import everything from the top-level indexes, which makes sorting things alphabetically by module name much easier. Testing Done: Ran js-tests.
bd39ea0be1d19e7d7acae0c4a9ca0f83e3893df6 David Trowbridge

Files

reviewboard/static/rb/js/common/actions/views/menuActionView.ts
reviewboard/static/rb/js/common/models/tests/commChannelModelTests.ts
reviewboard/static/rb/js/common/models/tests/userSessionModelTests.ts
reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
reviewboard/static/rb/js/common/resources/models/reviewModel.ts
reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
reviewboard/static/rb/js/reviews/models/unifiedBannerModel.ts
reviewboard/static/rb/js/reviews/models/tests/commentEditorModelTests.ts
reviewboard/static/rb/js/reviews/models/tests/diffViewerPageModelTests.ts
reviewboard/static/rb/js/reviews/models/tests/reviewablePageModelTests.ts
reviewboard/static/rb/js/reviews/views/commentDialogView.ts
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
reviewboard/static/rb/js/ui/views/textEditorView.ts
reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.ts
reviewboard/static/rb/js/common/actions/views/menuActionView.ts
reviewboard/static/rb/js/common/models/tests/commChannelModelTests.ts
reviewboard/static/rb/js/common/models/tests/userSessionModelTests.ts
reviewboard/static/rb/js/common/resources/collections/tests/resourceCollectionTests.ts
reviewboard/static/rb/js/common/resources/models/draftResourceModelMixin.ts
reviewboard/static/rb/js/common/resources/models/reviewModel.ts
reviewboard/static/rb/js/common/resources/models/reviewReplyModel.ts
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
reviewboard/static/rb/js/reviews/models/commentEditorModel.ts
reviewboard/static/rb/js/reviews/models/reviewablePageModel.ts
reviewboard/static/rb/js/reviews/models/unifiedBannerModel.ts
reviewboard/static/rb/js/reviews/models/tests/commentEditorModelTests.ts
reviewboard/static/rb/js/reviews/models/tests/diffViewerPageModelTests.ts
reviewboard/static/rb/js/reviews/models/tests/reviewablePageModelTests.ts
reviewboard/static/rb/js/reviews/views/commentDialogView.ts
reviewboard/static/rb/js/reviews/views/diffViewerPageView.ts
reviewboard/static/rb/js/reviews/views/reviewDialogView.ts
reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
reviewboard/static/rb/js/reviews/views/reviewRequestEditorView.ts
reviewboard/static/rb/js/reviews/views/reviewablePageView.ts
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
reviewboard/static/rb/js/reviews/views/tests/commentDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/diffViewerPageViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewDialogViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewRequestEditorViewTests.ts
reviewboard/static/rb/js/reviews/views/tests/reviewablePageViewTests.ts
reviewboard/static/rb/js/ui/views/textEditorView.ts
reviewboard/static/rb/js/ui/views/tests/textEditorViewTests.ts
Loading...