Port config forms JS codebase to TypeScript/spina.

Review Request #13140 — Created July 13, 2023 and submitted — Latest diff uploaded

Information

Djblets
release-4.x

Reviewers

This change ports the JavaScript side of the config forms app to use
TypeScript and spina.

For the most part this is a very straightforward port. The only annoying
thing was I discovered that the ListItem implementation allowed
passing in an actions parameter which was treated as an option arg,
but was actually being passed in as part of the attributes (despite not
being an attribute on the model). This was only used inside of our unit
tests (which have themselves been updated to use setActions), but I've
added some compatibility code to emit a deprecation warning just in the
very unlikely case that someone was using this.

Ran js-tests.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Port config forms JS codebase to TypeScript/spina.
This change ports the JavaScript side of the config forms app to use TypeScript and spina. For the most part this is a very straightforward port. The only annoying thing was I discovered that the `ListItem` implementation allowed passing in an `actions` parameter which was treated as an option arg, but was actually being passed in as part of the attributes (despite not being an attribute on the model). This was only used inside of our unit tests (which have themselves been updated to use `setActions`), but I've added some compatibility code to emit a deprecation warning just in the very unlikely case that someone was using this. Testing Done: Ran js-tests.
32853981b0755bb4adfc93b1510b40c92735de31 David Trowbridge

Files

djblets/staticbundles.py
djblets/static/djblets/js/configForms/index.ts
djblets/static/djblets/js/configForms/collections/listItemsCollection.ts
djblets/static/djblets/js/configForms/collections/listItemsCollection.es6.js Deleted
djblets/static/djblets/js/configForms/models/listItemModel.ts
djblets/static/djblets/js/configForms/models/listItemModel.es6.js Deleted
djblets/static/djblets/js/configForms/models/listModel.js Deleted
djblets/static/djblets/js/configForms/models/listModel.ts
djblets/static/djblets/js/configForms/models/tests/index.ts
djblets/static/djblets/js/configForms/models/tests/listItemModelTests.ts
djblets/static/djblets/js/configForms/models/tests/listItemModelTests.es6.js Deleted
djblets/static/djblets/js/configForms/views/listItemView.ts Was djblets/static/djblets/js/configForms/views/listItemView.es6.js
djblets/static/djblets/js/configForms/views/listView.ts Was djblets/static/djblets/js/configForms/views/listView.es6.js
djblets/static/djblets/js/configForms/views/pagesView.ts Was djblets/static/djblets/js/configForms/views/pagesView.es6.js
djblets/static/djblets/js/configForms/views/tableItemView.ts Was djblets/static/djblets/js/configForms/views/tableItemView.es6.js
djblets/static/djblets/js/configForms/views/tableView.ts Was djblets/static/djblets/js/configForms/views/tableView.es6.js
djblets/static/djblets/js/configForms/views/tests/index.ts
djblets/static/djblets/js/configForms/views/tests/listItemViewTests.ts Was djblets/static/djblets/js/configForms/views/tests/listItemViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/listViewTests.ts Was djblets/static/djblets/js/configForms/views/tests/listViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.ts Was djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/tableViewTests.ts Was djblets/static/djblets/js/configForms/views/tests/tableViewTests.es6.js
djblets/static/djblets/js/tests/index.ts
djblets/staticbundles.py
djblets/static/djblets/js/configForms/index.ts
djblets/static/djblets/js/configForms/collections/listItemsCollection.ts
djblets/static/djblets/js/configForms/collections/listItemsCollection.es6.js
djblets/static/djblets/js/configForms/models/listItemModel.ts
djblets/static/djblets/js/configForms/models/listItemModel.es6.js
djblets/static/djblets/js/configForms/models/listModel.js
djblets/static/djblets/js/configForms/models/listModel.ts
djblets/static/djblets/js/configForms/models/tests/index.ts
djblets/static/djblets/js/configForms/models/tests/listItemModelTests.ts
djblets/static/djblets/js/configForms/models/tests/listItemModelTests.es6.js
djblets/static/djblets/js/configForms/views/listItemView.es6.js
djblets/static/djblets/js/configForms/views/listView.es6.js
djblets/static/djblets/js/configForms/views/pagesView.es6.js
djblets/static/djblets/js/configForms/views/tableItemView.es6.js
djblets/static/djblets/js/configForms/views/tableView.es6.js
djblets/static/djblets/js/configForms/views/tests/index.ts
djblets/static/djblets/js/configForms/views/tests/listItemViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/listViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/tableItemViewTests.es6.js
djblets/static/djblets/js/configForms/views/tests/tableViewTests.es6.js
djblets/static/djblets/js/tests/index.ts
Loading...