• 
      

    Fix the spacing and layout for datagrid filters.

    Review Request #13136 — Created July 6, 2023 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    Datagrid filters (such as Show/Hide Archived) were lacking any suitable
    spacing, appearing right alongside the header or tabs. This gave a
    pretty ugly appearance.

    This change fixes that, adding some spacing between the title/tabs and
    filter, and between multiple filters. We don't currently use multiple
    filters anywhere, but in testing this, I found that multiple filters
    would be stacked vertically, rather than horizontally. This has been
    fixed as well.

    Tested the dashboard, users page, and other datagrids.

    Tested adding multiple filters.

    Summary ID
    Fix the spacing and layout for datagrid filters.
    Datagrid filters (such as Show/Hide Archived) were lacking any suitable spacing, appearing right alongside the header or tabs. This gave a pretty ugly appearance. This change fixes that, adding some spacing between the title/tabs and filter, and between multiple filters. We don't currently use multiple filters anywhere, but in testing this, I found that multiple filters would be stacked vertically, rather than horizontally. This has been fixed as well.
    102cacd48443dc500d31f0eaed31dbfd0b367439

    Description From Last Updated

    Why is this here twice?

    daviddavid
    maubin
    1. Ship It!
    2. 
        
    david
    1. 
        
    2. Show all issues

      Why is this here twice?

      1. That was added on just to show how things look when there are multiple filters, since we don't currently have any UI demonstrating the bug I mentioned in the description.

    3. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-6.x (1125743)