• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix the data sent with cross-tab reload events.
    
 
    

    



 
    
 
    

  Review Request #13102
  —
  Created June 7, 2023 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-6.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    I fat-fingered a rebase, resulting in the cross-tab reload event being
    
broken. The getReloadData() implementation within the
    
ReviewablePageView got moved to another class, which meant that the
    
reload data was always null. This meant that all tabs would force a
    
reload, including the dashboard and other review requests.
    
 
    

    





  

    
 
 
    
  
    Published a review from one tab and verified that the data sent with the
    
reload event to other tabs once again included the review request ID,
    
and that non-matching tabs didn't force a reload.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix the data sent with cross-tab reload events.
      
    I fat-fingered a rebase, resulting in the cross-tab reload event being
broken. The `getReloadData()` implementation within the
`ReviewablePageView` got moved to another class, which meant that the
reload data was always `null`. This meant that all tabs would force a
reload, including the dashboard and other review requests.

Testing Done:
Published a review from one tab and verified that the data sent with the
reload event to other tabs once again included the review request ID,
and that non-matching tabs didn't force a reload.
    
     
    

        		
    a3ab60d4e298fe73ec2e41058ba71e500e16d14c

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



maubin




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
maubin


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-6.x (24791b2)