Summary

Create pytest infrastructure in `rbext create`

Review Request #13084 — Created May 31, 2023 and submitted June 5, 2023, 4:26 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that we can use pytest in extensions, we want to create that as part
of creating a new extension. This change adds the machinery to generate
conftest.py and pyproject.toml files with the correct setup to run
tests.

Testing Done

Created a test extension and saw that it was set up to run tests.

Commits

Summary	ID
Create pytest infrastructure in `rbext create` Now that we can use pytest in extensions, we want to create that as part of creating a new extension. This change adds the machinery to generate `conftest.py` and `pyproject.toml` files with the correct setup to run tests. Testing Done: Created a test extension and saw that it was set up to run tests.	5288bb93231ac941318c8eee1da1324721d0d404

Issues

Description	From	Last Updated
We should probably generate a pyproject.toml instead, putting this there, and also stop generating a setup.py. I know that last …	chipx86	June 2, 2023, 6:14 p.m.
Are we able to set these in our fixtures file? Also wondering about that for many of these other options. …	chipx86	June 2, 2023, 6:10 p.m.
This is duplicated.	chipx86	June 5, 2023, 4:27 p.m.

flake8 passed.

JSHint passed.

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been resolved. Show all issues

We should probably generate a pyproject.toml instead, putting this there, and also stop generating a setup.py. I know that last part is outside the scope of this change, but with setup.py going away, that'll be important.

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been dropped. Show all issues

Are we able to set these in our fixtures file?

Also wondering about that for many of these other options. I suspect some can be, but I don't know.

david June 2, 2023, 5:49 p.m.

Setting environment variables from a fixture doesn't seem to work.

Change Summary:

Switch test config to pyproject.toml

Description:

		Now that we can use pytest in extensions, we want to create that as part
		of creating a new extension. This change adds the machinery to generate
~		`conftest.py` and `setup.cfg` files with the correct setup to run tests.
~
	~	`conftest.py` and `pyproject.toml` files with the correct setup to run
	~	tests.
-		Testing Done:
-		Created a test extension and saw that it was set up to run tests.

Commits:

	Summary	ID
	Create pytest infrastructure in `rbext create` Now that we can use pytest in extensions, we want to create that as part of creating a new extension. This change adds the machinery to generate `conftest.py` and `setup.cfg` files with the correct setup to run tests. Testing Done: Created a test extension and saw that it was set up to run tests.	12d7d10cd0c1a8a2d3c42758a4a09f386a50ffe1
	Create pytest infrastructure in `rbext create` Now that we can use pytest in extensions, we want to create that as part of creating a new extension. This change adds the machinery to generate `conftest.py` and `pyproject.toml` files with the correct setup to run tests. Testing Done: Created a test extension and saw that it was set up to run tests.	5288bb93231ac941318c8eee1da1324721d0d404

Diff:

Revision 2 (+158)

Show changes

reviewboard/cmdline/rbext.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/cmdline/rbext.py (Diff revision 2)

The issue has been resolved. Show all issues

This is duplicated.

Status:: Completed
Change Summary:: Pushed to release-6.x (81398ef)