Summary

Review Board issue 1440: comment flag not visible in view diffs

Review Request #1308 — Created Dec. 23, 2009 and submitted

Information

Owner

lonico

Repository

Review Board

Branch

Bugs

1440

Depends On

Reviewers

Groups

reviewboard

People

Description

Review Board issue 1440: comment flag not visible in view diffs
Some miscalculation in rb javascript may cause a comment flag not
to be shown in the diff view.  The comment is still present in the
DB and is shown in the reviews view.
Also improved the code around guessRowNum, so it may be a bit speedier 
if the commented line is close to the row being examined.

Testing Done

Performed UT and Integration Testing using firebug.

Verified that the initial issue reported by end user is fixed for their diffs.

reviewboard/htdocs/media/rb/js/diffviewer.js (Diff revision 1)

I'm not sure I understand the value of this.
Is this protecting against some boundary 
condition?  Otherwise, I'd like to remove it.

reviewboard/htdocs/media/rb/js/diffviewer.js (Diff revision 1)

It's a bit of overkill, as i++ would always have worked for me, but it seems like a big assumption.

Ship it!

Looks good. Committed to master as f7778d4.