Summary

Add pytest mode to djblets.testing.testrunners.TestRunner.

Review Request #13075 — Created May 30, 2023 and submitted June 5, 2023, 9:25 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We've mostly phased out nose from our own usage, but it's still being
used for the extension test runner. The behavior is different enough
that we need a transition period to move people over.

In most cases, once extensions are configured in a way to make use of
pytest, they'll be able to just run pytest instead of rbext test,
but we also want latter to continue to exist.

This change adds a mode to the TestRunner to use pytest instead of nose.
That can be opted into for now, and in a future version we'll switch it
over and remove the nose mode.

Testing Done

Ran rbintegrations tests via pytest and our test runner.

Commits

Summary	ID
Add pytest mode to djblets.testing.testrunners.TestRunner. We've mostly phased out nose from our own usage, but it's still being used for the extension test runner. The behavior is different enough that we need a transition period to move people over. In most cases, once extensions are configured in a way to make use of pytest, they'll be able to just run `pytest` instead of `rbext test`, but we also want latter to continue to exist. This change adds a mode to the TestRunner to use pytest instead of nose. That can be opted into for now, and in a future version we'll switch it over and remove the nose mode. Testing Done: Ran rbintegrations tests via pytest and our test runner.	40f67ca4d0ec8fc94dc1f95cc38c03737b921db5

Summary

Add pytest mode to djblets.testing.testrunners.TestRunner.

We've mostly phased out nose from our own usage, but it's still being used for the extension test runner. The behavior is different enough that we need a transition period to move people over. In most cases, once extensions are configured in a way to make use of pytest, they'll be able to just run `pytest` instead of `rbext test`, but we also want latter to continue to exist. This change adds a mode to the TestRunner to use pytest instead of nose. That can be opted into for now, and in a future version we'll switch it over and remove the nose mode. Testing Done: Ran rbintegrations tests via pytest and our test runner.

40f67ca4d0ec8fc94dc1f95cc38c03737b921db5

Issues

Description	From	Last Updated
Let's make both of these conditional. An extension may not have either of these installed, or may have only one …	chipx86	May 31, 2023, 3:39 p.m.
This needs a Version Added.	chipx86	May 31, 2023, 3:39 p.m.
This needs a Version Added.	chipx86	May 31, 2023, 3:39 p.m.
Parameters should start on the next line, indented one level. Function should have -> None at the end.	chipx86	May 31, 2023, 3:40 p.m.
Missing : bool. Otherwise this is Literal[False].	chipx86	May 31, 2023, 3:40 p.m.
And pytest_options.	chipx86	May 31, 2023, 3:40 p.m.
Both of these should have Version Added.	chipx86	May 31, 2023, 3:40 p.m.
No pass here.	chipx86	May 31, 2023, 3:41 p.m.
str, not unicode.	chipx86	May 31, 2023, 3:41 p.m.

flake8 passed.

JSHint passed.

djblets/testing/testrunners.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's make both of these conditional. An extension may not have either of these installed, or may have only one as we transition.

djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs a Version Added.
```
djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This needs a Version Added.
```

djblets/testing/testrunners.py (Diff revision 1)

The issue has been resolved. Show all issues

Parameters should start on the next line, indented one level. Function should have -> None at the end.

djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing : bool. Otherwise this is Literal[False].
```
djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
And pytest_options.
```

djblets/testing/testrunners.py (Diff revision 1)

The issue has been resolved. Show all issues

Both of these should have Version Added.

djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
No pass here.
```
djblets/testing/testrunners.py (Diff revision 1)
The issue has been resolved. Show all issues
```
str, not unicode.
```

Commits:

	Summary	ID
	Add pytest mode to djblets.testing.testrunners.TestRunner. We've mostly phased out nose from our own usage, but it's still being used for the extension test runner. The behavior is different enough that we need a transition period to move people over. In most cases, once extensions are configured in a way to make use of pytest, they'll be able to just run `pytest` instead of `rbext test`, but we also want latter to continue to exist. This change adds a mode to the TestRunner to use pytest instead of nose. That can be opted into for now, and in a future version we'll switch it over and remove the nose mode. Testing Done: Ran rbintegrations tests via pytest and our test runner.	fdfe4c1a38e20a6073bfbda6423769f1b84e1fea
	Add pytest mode to djblets.testing.testrunners.TestRunner. We've mostly phased out nose from our own usage, but it's still being used for the extension test runner. The behavior is different enough that we need a transition period to move people over. In most cases, once extensions are configured in a way to make use of pytest, they'll be able to just run `pytest` instead of `rbext test`, but we also want latter to continue to exist. This change adds a mode to the TestRunner to use pytest instead of nose. That can be opted into for now, and in a future version we'll switch it over and remove the nose mode. Testing Done: Ran rbintegrations tests via pytest and our test runner.	40f67ca4d0ec8fc94dc1f95cc38c03737b921db5

Diff:

Revision 2 (+316 -60)

Show changes

djblets/testing/testrunners.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (38ab901)