flake8
passed.
JSHint
passed.
Review Request #13064 — Created May 24, 2023 and submitted
This introduces type hints for some of our most important underlying
structures in Review Board. Types are now available forSCMTool
,
SCMClient
,Branch
,Commit
,ChangeSet
,Revision
,
FileLookupContext
, and_SCMToolIDProperty
.This should help ensure proper usage of these classes, and proper
implementation of new SCMTools.Some typing errors and and bad documentation were uncovered while
adding types. For instance,Popen
had a bad string conversion and
bad documented return type, and some objects had unsafe comparison
logic. These have been fixed.
Unit tests pass.
Summary | ID |
---|---|
f308f1e77fc131da5509f323d9814628a8c08685 |
Moved to release-6.x.
Summary | ID | |
---|---|---|
52606f8a0f7a5fe50020f61be64e8281070a5f34 | ||
f308f1e77fc131da5509f323d9814628a8c08685 |
Revision 2 (+684 -340)