Summary

Fix style regression for diff change descriptions.

Review Request #13057 — Created May 22, 2023 and submitted May 24, 2023, 10:13 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The change descriptions for diffs use the same .diff-index class as

the file listing in the diffs. Unfortunately, some of the styles for

that class were moved to the listing's parent container in order to

facilitate the new docking behavior, which caused the look of diff

change descriptions to regress.
This change copies over the few styles we need in order for this to look

correct.

Testing Done

Published some updated diffs and saw the "Diff" entry in the change
description box looked correct.

Commits

Summary	ID
Fix style regression for diff change descriptions. The change descriptions for diffs use the same `.diff-index` class as the file listing in the diffs. Unfortunately, some of the styles for that class were moved to the listing's parent container in order to facilitate the new docking behavior, which caused the look of diff change descriptions to regress. This change copies over the few styles we need in order for this to look correct. Testing Done: Published some updated diffs and saw the "Diff" entry in the change description box looked correct.	570986c4bd1bc97bf0abf3d2fd8330c65fc7daa7

Summary

Fix style regression for diff change descriptions.

The change descriptions for diffs use the same `.diff-index` class as the file listing in the diffs. Unfortunately, some of the styles for that class were moved to the listing's parent container in order to facilitate the new docking behavior, which caused the look of diff change descriptions to regress. This change copies over the few styles we need in order for this to look correct. Testing Done: Published some updated diffs and saw the "Diff" entry in the change description box looked correct.

570986c4bd1bc97bf0abf3d2fd8330c65fc7daa7

Issues

Description	From	Last Updated
Should we use @white here instead	maubin	May 24, 2023, 10:03 a.m.

flake8 passed.

JSHint passed.

reviewboard/static/rb/css/pages/reviews.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we use @white here instead
```

Commits:

	Summary	ID
	Fix style regression for diff change descriptions. The change descriptions for diffs use the same `.diff-index` class as the file listing in the diffs. Unfortunately, some of the styles for that class were moved to the listing's parent container in order to facilitate the new docking behavior, which caused the look of diff change descriptions to regress. This change copies over the few styles we need in order for this to look correct. Testing Done: Published some updated diffs and saw the "Diff" entry in the change description box looked correct.	66ba23e3935cdea8d9f64ab5286cc218aa8cc5a7
	Fix style regression for diff change descriptions. The change descriptions for diffs use the same `.diff-index` class as the file listing in the diffs. Unfortunately, some of the styles for that class were moved to the listing's parent container in order to facilitate the new docking behavior, which caused the look of diff change descriptions to regress. This change copies over the few styles we need in order for this to look correct. Testing Done: Published some updated diffs and saw the "Diff" entry in the change description box looked correct.	570986c4bd1bc97bf0abf3d2fd8330c65fc7daa7

Diff:

Revision 2 (+4)

Show changes

reviewboard/static/rb/css/pages/reviews.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (1b6d562)