Move all base command support into rbtools.commands.base.
Review Request #13021 — Created May 6, 2023 and submitted
Modules in
rbtools.commands.base
now provide all the base command
classes, option processing, output handling, and errors. This cleans up
therbtools.commands
module and gives us room for further expansion.This work was planned for RBTools 4, but had to slip.
With the exception of the, well, exception classes, all classes use
housekeeping.ClassMovedMixin
to point to the new class. We don't
bother subclassing the old exceptions because catching a subclass
wouldn't do any good. We can't easily deprecate those, for the
time-being, we'll leave them in, directly assigning from the new
modules.The moved classes have not been modernized. Aside from imports and
version change information in the docstrings, no changes have been made
to any of the moved code.
Unit tests pass, except for one that's sensitive to generated output
and is seeing a warning. This will be addressed in a follow-up change.
Summary | ID |
---|---|
785ea25c142f3c1578024415911506aff05f4b70 |
Description | From | Last Updated |
---|---|---|
Typo in summary: "Mov" -> "Move" |
maubin | |
redefinition of unused 'BaseSubCommand' from line 8 Column: 1 Error code: F811 |
reviewbot | |
redefinition of unused 'BaseMultiCommand' from line 8 Column: 1 Error code: F811 |
reviewbot | |
'rbtools.deprecation.RemovedInRBTools60Warning' imported but unused Column: 1 Error code: F401 |
reviewbot | |
'rbtools.utils.filesystem.is_exe_in_path' imported but unused Column: 1 Error code: F401 |
reviewbot | |
undefined name 'json' Column: 35 Error code: F821 |
reviewbot | |
undefined name 'six' Column: 37 Error code: F821 |
reviewbot |