This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-3.x (623658e)

Summary

Add type hints for IntegrationManager.

Review Request #12994 — Created April 27, 2023 and submitted 1 year, 10 months ago — Latest diff uploaded 1 year, 10 months ago

Information

Owner

chipx86*

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

This adds type hints for IntegrationManager, helping ensure that code
interacting with an IntegrationManager passes around the right types.
These type hints also cover instance variables, letting IDEs and type
checkers show details on these attributes.

Testing Done

Unit tests, mypy, and pyright pass.

Changes between revision 2 and 3

orig

Commits

	Summary	ID	Author
	Add type hints for IntegrationManager. This adds type hints for `IntegrationManager`, helping ensure that code interacting with an `IntegrationManager` passes around the right types. These type hints also cover instance variables, letting IDEs and type checkers show details on these attributes.	bc83879805ed79c59a5c96a41d2830fe22606391	Christian Hammond
	Add type hints for IntegrationManager. This adds type hints for `IntegrationManager`, helping ensure that code interacting with an `IntegrationManager` passes around the right types. These type hints also cover instance variables, letting IDEs and type checkers show details on these attributes.	da8306cfb039eeda2ba4106ba6c5075450084df6	Christian Hammond

Files

	djblets/integrations/integration.py
	djblets/integrations/manager.py

djblets/integrations/integration.py

djblets/integrations/manager.py