Improve related object selectors in conditions.

Review Request #12987 — Created April 25, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

The object selectors in the conditions UI leave a fair bit to be
desired. They end up rendering as <select multiple>, which isn't a
particularly great UI, and the results were displaying in whatever order
the database was giving us.

I'm continuing to investigate whether we have better options for the
widgets, but for now this change fixes up the ordering for repositories,
repository types, and groups to sort alphabetically instead of randomly.

Verified that related object selectors in conditions had better
ordering.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Improve related object selectors in conditions.
The object selectors in the conditions UI leave a fair bit to be desired. They end up rendering as `<select multiple>`, which isn't a particularly great UI, and the results were displaying in whatever order the database was giving us. I'm continuing to investigate whether we have better options for the widgets, but for now this change fixes up the ordering for repositories, repository types, and groups to sort alphabetically instead of randomly. Testing Done: Verified that related object selectors in conditions had better ordering.
1e946334b73bea4e48c71fb2cf579c5240bd67a8 David Trowbridge
reviewboard/reviews/conditions.py
reviewboard/scmtools/conditions.py
Loading...