Add a JavaScript hook for extending the File Attachment thumbnail container UI.
Review Request #12951 — Created April 19, 2023 and submitted
This adds a JavaScript hook for extending the File Attachment thumbnail
container UI. The hook can be used to display additional content on
file attachment thumbnails and in the file attachment actions menu.This also adds a method to the File Attachment thumbnail view that allows
callers to add an action to the file attachment actions menu.
- Ran JS unit tests.
- Ran unit tests.
- Manually tested with the new "Download as PDF" action that's being added in
in Power Pack. - Manually tested with a simple extension and view, the one in the example
in the docs. - Built the docs and made sure they look ok.
| Summary | ID |
|---|---|
| 6f449b1cf964645cc794bcf7207e5da520f664b7 |
| Description | From | Last Updated |
|---|---|---|
|
Missing semicolon. Column: 11 Error code: W033 |
 reviewbot
|
|
|
Missing semicolon. Column: 12 Error code: W033 |
reviewbot
|
|
|
Missing semicolon. Column: 34 Error code: W033 |
reviewbot
|
|
|
line too long (87 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
|
|
I think it would be nicer to use a template literal here instead of + |
 david
|
|
|
Let's call this $appendItem. It would also be nicer to use a template literal here instead of + |
david
|
|
|
line too long (87 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
|
|
'$appendItem' is defined but never used. Column: 15 Error code: W098 |
reviewbot
|
|
|
line too long (87 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
|
|
The ==== lines should be the same width as the name |
david
|
|
|
Let's sort these alphabetically. |
david
|
|
|
Sort alphabetically. |
david
|
|
|
Sort alphabetically. |
david
|
|
|
Sort alphabetically. |
david
|
|
|
line too long (87 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
|
|
line too long (87 > 79 characters) Column: 80 Error code: E501 |
reviewbot
|
- Change Summary:
-
Added some missing semicolons.
- Commits:
-
Summary ID 125d1de81d3f009bd96ff33d557faec2d83e7ab1 76c0ca916355428e4bd5e055520acb99c835f664 - Diff:
-
Revision 2 (+676 -2)
- Commits:
-
Summary ID 76c0ca916355428e4bd5e055520acb99c835f664 4f098d5199967e715297e5abe70bb0ac4891f2d6 - Diff:
-
Revision 3 (+678 -2)
- Commits:
-
Summary ID 4f098d5199967e715297e5abe70bb0ac4891f2d6 ed0688ed38ca41b6429c57ead4bafb86f587f4a3 - Diff:
-
Revision 4 (+678 -2)
- Commits:
-
Summary ID ed0688ed38ca41b6429c57ead4bafb86f587f4a3 6f449b1cf964645cc794bcf7207e5da520f664b7 - Diff:
-
Revision 5 (+700 -22)