Convert to spina 2

 






 

 


  Review Request #12934
  —
  Created April 4, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates our existing spina code for the new 2.0 version. The

bulk of this is just moving various attributes like defaults and

events to be static.

 








  


 
 

  
    

  • Ran unit tests.
    • 

  • Ran with other changes that make use of more involved Spina 2 changes,
    
  such as converting a base class while subclasses are still using
    
.extend().
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert to spina 2
     
This change updates our existing spina code for the new 2.0 version. The
bulk of this is just moving various attributes like `defaults` and
`events` to be `static`.

Testing Done:
- Ran unit tests.
- Ran with other changes that make use of more involved Spina 2 changes,
  such as converting a base class while subclasses are still using
  `.extend()`.

    

   
  		
  d1e9f798194fea0a9845f844c96854d5a6430c72
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      package-lock.json
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/actions/models/action.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/actions/models/menuAction.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/common/actions/views/menuActionView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/models/unifiedBanner.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/reviewRequestActions.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuButtonView.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...