• 
      

    Fix updates when publishing/discarding from the review dialog.

    Review Request #12931 — Created April 4, 2023 and submitted — Latest diff uploaded

    Information

    Review Board
    release-6.x

    Reviewers

    The new review banner worked correctly when publishing or discarding
    from the banner, but the page would fail to update correctly when
    publishing or discarding from the review dialog.

    This fix involved changes in two places:
    1. In the unified banner, we listened to the destroyed signal for the
    draft review instead of destroy. destroy is emitted too soon, and
    gets handled before the model has reset its attributes.
    2. In the review dialog, when publishing, we explicitly reload the page
    at the end of the process.

    Published and discarded reviews from the review dialog. Saw everything
    update correctly.

    Commits

    Files