flake8
passed.
JSHint
passed.
Fix updates when publishing/discarding from the review dialog.
Review Request #12931 — Created April 3, 2023 and submitted
The new review banner worked correctly when publishing or discarding
from the banner, but the page would fail to update correctly when
publishing or discarding from the review dialog.This fix involved changes in two places:
1. In the unified banner, we listened to thedestroyedsignal for the
draft review instead ofdestroy.destroyis emitted too soon, and
gets handled before the model has reset its attributes.
2. In the review dialog, when publishing, we explicitly reload the page
at the end of the process.
Published and discarded reviews from the review dialog. Saw everything
update correctly.
| Summary | ID |
|---|---|
| 78b78509c41641c2b224d8a47e84fabbcbaf5fef |
| Description | From | Last Updated |
|---|---|---|
|
Typo in the description: "listed to the ..." -> "listened to the ..." |
 chipx86
|
- Description:
-
The new review banner worked correctly when publishing or discarding
from the banner, but the page would fail to update correctly when publishing or discarding from the review dialog. This fix involved changes in two places:
~ 1. In the unified banner, we listed to the destroyedsignal for the~ 1. In the unified banner, we listened to the destroyedsignal for thedraft review instead of destroy.destroyis emitted too soon, andgets handled before the model has reset its attributes. 2. In the review dialog, when publishing, we explicitly reload the page at the end of the process.