Summary

Fix updates when publishing/discarding from the review dialog.

Review Request #12931 — Created April 3, 2023 and submitted April 3, 2023, 9:43 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The new review banner worked correctly when publishing or discarding
from the banner, but the page would fail to update correctly when
publishing or discarding from the review dialog.

This fix involved changes in two places:
1. In the unified banner, we listened to the destroyed signal for the
draft review instead of destroy. destroy is emitted too soon, and
gets handled before the model has reset its attributes.
2. In the review dialog, when publishing, we explicitly reload the page
at the end of the process.

Testing Done

Published and discarded reviews from the review dialog. Saw everything
update correctly.

Commits

Summary	ID
Fix updates when publishing/discarding from the review dialog. The new review banner worked correctly when publishing or discarding from the banner, but the page would fail to update correctly when publishing or discarding from the review dialog. This fix involved changes in two places: 1. In the unified banner, we listed to the `destroyed` signal for the draft review instead of `destroy`. `destroy` is emitted too soon, and gets handled before the model has reset its attributes. 2. In the review dialog, when publishing, we explicitly reload the page at the end of the process. Testing Done: Published and discarded reviews from the review dialog. Saw everything update correctly.	78b78509c41641c2b224d8a47e84fabbcbaf5fef

Summary

Fix updates when publishing/discarding from the review dialog.

The new review banner worked correctly when publishing or discarding from the banner, but the page would fail to update correctly when publishing or discarding from the review dialog. This fix involved changes in two places: 1. In the unified banner, we listed to the `destroyed` signal for the draft review instead of `destroy`. `destroy` is emitted too soon, and gets handled before the model has reset its attributes. 2. In the review dialog, when publishing, we explicitly reload the page at the end of the process. Testing Done: Published and discarded reviews from the review dialog. Saw everything update correctly.

78b78509c41641c2b224d8a47e84fabbcbaf5fef

Issues

Description	From	Last Updated
Typo in the description: "listed to the ..." -> "listened to the ..."	chipx86	April 3, 2023, 9:32 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Typo in the description: "listed to the ..." -> "listened to the ..."

Description:: The new review banner worked correctly when publishing or discarding
from the banner, but the page would fail to update correctly when
publishing or discarding from the review dialog.

This fix involved changes in two places:
~ 1. In the unified banner, we listed to the destroyed signal for the
~ 1. In the unified banner, we listened to the destroyed signal for the
draft review instead of destroy. destroy is emitted too soon, and
gets handled before the model has reset its attributes.
2. In the review dialog, when publishing, we explicitly reload the page
at the end of the process.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (6d7f19c)

		The new review banner worked correctly when publishing or discarding
		from the banner, but the page would fail to update correctly when
		publishing or discarding from the review dialog.

		This fix involved changes in two places:
~		1. In the unified banner, we listed to the `destroyed` signal for the
	~	1. In the unified banner, we listened to the `destroyed` signal for the
		draft review instead of `destroy`. `destroy` is emitted too soon, and
		gets handled before the model has reset its attributes.
		2. In the review dialog, when publishing, we explicitly reload the page
		at the end of the process.