Summary

Fix a usage of deprecated token generation API.

Review Request #12925 — Created March 27, 2023 and submitted March 29, 2023, 9:18 a.m.

Information

Owner

david

Repository

rbintegrations

Branch

master

Bugs

Depends On

Reviewers

Groups

rbintegrations

People

Description

The token generation API now requires passing certain parameters into

generate_token. The base CI class was still using the deprecated

version, which will no longer work after Djblets 4.0 beta 2.

Testing Done

Ran unit tests (previously failed).

Commits

Summary	ID
Fix a usage of deprecated token generation API. The token generation API now requires passing certain parameters into `generate_token`. The base CI class was still using the deprecated version, which will no longer work after Djblets 4.0 beta 2. Testing Done: Ran unit tests (previously failed).	75facc590d918f12ff569a2c270a67ceaf772593

Issues

Description	From	Last Updated
unexpected spaces around keyword / parameter equals Column: 35 Error code: E251	reviewbot	March 27, 2023, 3:36 p.m.
unexpected spaces around keyword / parameter equals Column: 37 Error code: E251	reviewbot	March 27, 2023, 3:36 p.m.
unexpected spaces around keyword / parameter equals Column: 35 Error code: E251	reviewbot	March 27, 2023, 3:36 p.m.
unexpected spaces around keyword / parameter equals Column: 37 Error code: E251	reviewbot	March 27, 2023, 3:36 p.m.

flake8 failed.

JSHint passed.

flake8

rbintegrations/baseci/integration.py (Diff revision 1)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 35
Error code: E251
```
rbintegrations/baseci/integration.py (Diff revision 1)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 37
Error code: E251
```
rbintegrations/baseci/integration.py (Diff revision 1)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 35
Error code: E251
```
rbintegrations/baseci/integration.py (Diff revision 1)
The issue has been dropped. Show all issues
```
unexpected spaces around keyword / parameter equals

Column: 37
Error code: E251
```

Commits:

	Summary	ID
	Fix a usage of deprecated token generation API. The token generation API now requires passing certain parameters into `generate_token`. The base CI class was still using the deprecated version, which will no longer work after Djblets 4.0 beta 2. Testing Done: Ran unit tests (previously failed).	b4909a1570efb8f8faca1cee7bcbbb44ff7ac7fd
	Fix a usage of deprecated token generation API. The token generation API now requires passing certain parameters into `generate_token`. The base CI class was still using the deprecated version, which will no longer work after Djblets 4.0 beta 2. Testing Done: Ran unit tests (previously failed).	75facc590d918f12ff569a2c270a67ceaf772593

Diff:

Revision 2 (+22 -4)

Show changes

rbintegrations/baseci/integration.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (77a09e0)