Allow plain objects to be used as mixins to Spina classes.

 






 

 


  Review Request #12905
  —
  Created March 21, 2023 and submitted 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Spina
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  beanbag-misc
 









 
 

  
 






 








 





  


 
 

  
Previously, mixins had to be class definitions with a prototype. Now,

they can be plain objects as well.


This enhances the capabilities of mixins, allowing interoperability with

mixins in legacy Backbone codebases that previously used _.extend() to

mix prototypes together.

 








  


 
 

  
Made use of this in Review Board with plain objects and classes as mixins.

They properly mixed in.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Allow plain objects to be used as mixins to Spina classes.
      
Previously, mixins had to be class definitions with a prototype. Now,
they can be plain objects as well.

This enhances the capabilities of mixins, allowing interoperability with
mixins in legacy Backbone codebases that previously used `_.extend()` to
mix prototypes together.

     


    		
    83231b274a1d71e63ef2f3fb0f05a4a4ad3f5a1f

   



  
 




 













 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
This can be const name because we don't reassign it in the body of the loop.

      		
      
       daviddavid
      
      
       
      
     


    
   

  

 







 






  

 



















 




 




 














 





 

  

   




david




   

   









  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       src/objects.ts
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    This can be const name because we don't reassign it in the body of the loop.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to master (94fe54b)