Fix a couple bugs in the unified banner.

 






 

 


  Review Request #12899
  —
  Created March 21, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change fixes up two issues we've found while testing the unified

banner:


    

  1. Selecting a single review reply and then clicking "Publish" would end
    
   up publishing all replies. This was due to a conditional that needed
    
   to be done in the opposite order.
    2. 

  2. A last-minute change for the handler that scrolls to the selected
    
   review reply left it with some undefined variable errors (since we
    
   were no longer getting the model from the arguments). This has been
    
   fixed to use this.model.
    3. 


 








  


 
 

  
Verified that both bugs were fixed.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix a couple bugs in the unified banner.
     
This change fixes up two issues we've found while testing the unified
banner:

1. Selecting a single review reply and then clicking "Publish" would end
   up publishing all replies. This was due to a conditional that needed
   to be done in the opposite order.
2. A last-minute change for the handler that scrolls to the selected
   review reply left it with some undefined variable errors (since we
   were no longer getting the model from the arguments). This has been
   fixed to use `this.model`.

Testing Done:
Verified that both bugs were fixed.

    

   
  		
  91382d2036455c3003e7c43408626f528ab67918
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
     
    

   
  

 










     

    

   

  

  

   
   Loading...