• 
      

    Fix creating diffs for UCM activities whose changes are in other VOBs.

    Review Request #12894 — Created March 15, 2023 and submitted

    Information

    RBTools
    release-4.x

    Reviewers

    One of our more recent changes to improve the versioning of elements in
    ClearCase/VersionVault introduced a problem where if the element was not inside
    the same VOB as the CWD, we'd hit an error trying to query for its version. This
    change adds the VOB UUID as a part of the path that we query, allowing this to
    work across VOBs.

    Posted a UCM activity where all of the changes existed in a VOB other than the
    one in my CWD. Before this change, I was getting an error executing cleartool.
    After, the diff is posted successfully.

    Summary ID
    Fix creating diffs for UCM activities whose changes are in other VOBs.
    One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.
    ebb42f7c7ce3efa6ce0b835a26d1752999bf3525
    Description From Last Updated

    blank line contains whitespace Column: 1 Error code: W293

    reviewbotreviewbot

    line too long (87 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot

    line too long (83 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot

    line too long (82 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot

    line too long (87 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot

    line too long (83 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot

    line too long (82 > 79 characters) Column: 80 Error code: E501

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    david
    Review request changed
    Commits:
    Summary ID
    Fix creating diffs for UCM activities whose changes are in other VOBs.
    One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.
    053d93eb66760d4ed64f58006cb91e5b7033a5a4
    Fix creating diffs for UCM activities whose changes are in other VOBs.
    One of our more recent changes to improve the versioning of elements in ClearCase/VersionVault introduced a problem where if the element was not inside the same VOB as the CWD, we'd hit an error trying to query for its version. This change adds the VOB UUID as a part of the path that we query, allowing this to work across VOBs. Testing Done: Posted a UCM activity where all of the changes existed in a VOB other than the one in my CWD. Before this change, I was getting an error executing cleartool. After, the diff is posted successfully.
    ebb42f7c7ce3efa6ce0b835a26d1752999bf3525

    Checks run (1 failed, 1 succeeded)

    flake8 failed.
    JSHint passed.

    flake8

    maubin
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-4.x (df83d02)