Remove deprecated code from Review Board.

Review Request #12885 — Created March 14, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

This change removes all RemovedInReviewBoard60 things from our codebase.
The only complicated part of this is that the mercurial diff parsers
were still using the old get_orig_commit_id method, so those have been
updated to set the data correctly on the ParsedDiffChange.

This also makes one small fix to the filediff API resource to handle a
deprecation removal in Djblets.

Ran unit tests.

Diff Revision 4

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

orig
1
2
3
4
5
6

Commits

First Last Summary ID Author
Remove deprecated code from Review Board.
This change removes all RemovedInReviewBoard60 things from our codebase. The only complicated part of this is that the mercurial diff parsers were still using the old `get_orig_commit_id` method, so those have been updated to set the data correctly on the `ParsedDiffChange`. This also makes one small fix to the filediff API resource to handle a deprecation removal in Djblets. Testing Done: Ran unit tests.
fccadb70734d3e6e1d94faa0ff3f554ab4ea6eac David Trowbridge
reviewboard/deprecation.py
reviewboard/admin/checks.py
reviewboard/admin/widgets.py
reviewboard/admin/forms/search_settings.py
reviewboard/admin/tests/test_search_settings_form.py
reviewboard/diffviewer/chunk_generator.py
reviewboard/diffviewer/diffutils.py
reviewboard/diffviewer/parser.py
reviewboard/diffviewer/renderers.py
reviewboard/diffviewer/tests/test_diff_chunk_generator.py
reviewboard/diffviewer/tests/test_diff_parser.py
reviewboard/diffviewer/tests/test_diff_renderer.py
reviewboard/diffviewer/tests/test_diffutils.py
reviewboard/diffviewer/tests/test_forms.py
reviewboard/diffviewer/tests/test_raw_diff_chunk_generator.py
reviewboard/hostingsvcs/managers.py
reviewboard/integrations/__init__.py
reviewboard/reviews/managers.py
reviewboard/reviews/tests/test_review_group_manager.py
reviewboard/reviews/ui/text.py
reviewboard/scmtools/forms.py
reviewboard/scmtools/hg.py
reviewboard/scmtools/managers.py
reviewboard/scmtools/models.py
reviewboard/scmtools/registry.py
reviewboard/scmtools/tests/test_registry.py
reviewboard/scmtools/tests/test_repository_form.py
reviewboard/scmtools/tests/test_repository_manager.py
reviewboard/webapi/resources/filediff.py
Loading...