Remove deprecated code from Review Board.

 






 

 


  Review Request #12885
  —
  Created March 14, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change removes all RemovedInReviewBoard60 things from our codebase.

The only complicated part of this is that the mercurial diff parsers

were still using the old get_orig_commit_id method, so those have been

updated to set the data correctly on the ParsedDiffChange.


This also makes one small fix to the filediff API resource to handle a

deprecation removal in Djblets.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4
5
6

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Remove deprecated code from Review Board.
     
This change removes all RemovedInReviewBoard60 things from our codebase.
The only complicated part of this is that the mercurial diff parsers
were still using the old `get_orig_commit_id` method, so those have been
updated to set the data correctly on the `ParsedDiffChange`.

This also makes one small fix to the filediff API resource to handle a
deprecation removal in Djblets.

Testing Done:
Ran unit tests.

    

   
  		
  8ddd63cc917721bd5c693b816097a5d7de1e275a
  David Trowbridge
 


 
  
 
 
  
   
    

     Remove deprecated code from Review Board.
     
This change removes all RemovedInReviewBoard60 things from our codebase.
The only complicated part of this is that the mercurial diff parsers
were still using the old `get_orig_commit_id` method, so those have been
updated to set the data correctly on the `ParsedDiffChange`.

This also makes one small fix to the filediff API resource to handle a
deprecation removal in Djblets.

Testing Done:
Ran unit tests.

    

   
  		
  fccadb70734d3e6e1d94faa0ff3f554ab4ea6eac
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/deprecation.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/widgets.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/diffutils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/renderers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_renderer.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffutils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_raw_diff_chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/text.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/managers.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...