Hide change description field in unified banner depending on mode.

Review Request #12876 — Created March 9, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

It was a little bit confusing to have the change description field
displayed when the selected draft mode was unrelated to review request
changes. This updates the visibility calculations so we hide that field
when the banner is controlling only review or reply drafts.

Flipped around with different modes and saw the change description field
properly visible only when the selected mode includes the review request
changes.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Hide change description field in unified banner depending on mode.
It was a little bit confusing to have the change description field displayed when the selected draft mode was unrelated to review request changes. This updates the visibility calculations so we hide that field when the banner is controlling only review or reply drafts. Testing Done: Flipped around with different modes and saw the change description field properly visible only when the selected mode includes the review request changes.
b041ff459f2282b1c5d5f39b41f4c070b9e1d3d9 David Trowbridge
reviewboard/static/rb/js/reviews/views/unifiedBannerView.ts
Loading...