Port RB.MenuButtonView to TypeScript and spina, remove SplitButtonView.

 






 

 


  Review Request #12824
  —
  Created Feb. 3, 2023 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-6.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change ports the MenuButtonView UI element over to our new

TypeScript/spina framework.


The MenuButtonView had mostly replaced the old SplitButtonView,

which had been marked as deprecated since 4.0 (and which had become a

simple wrapper). As part of this change, I've moved the couple old uses

of SplitButtonView over to use MenuButtonView directly.

 








  


 
 

  
    

  • Verified "Publish" button functionality on the review dialog and draft
    
  review banner.
    • 

  • Ran js-tests.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Port RB.MenuButtonView to TypeScript and spina, remove SplitButtonView.
     
This change ports the MenuButtonView UI element over to our new
TypeScript/spina framework.

The `MenuButtonView` had mostly replaced the old `SplitButtonView`,
which had been marked as deprecated since 4.0 (and which had become a
simple wrapper). As part of this change, I've moved the couple old uses
of SplitButtonView over to use MenuButtonView directly.

Testing Done:
- Verified "Publish" button functionality on the review dialog and draft
  review banner.
- Ran js-tests.

    

   
  		
  ed1a24257f057c3a4b40644f083400253fd51ab9
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/index.ts
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuButtonView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/menuView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/splitButtonView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/menuButtonViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/draftReviewBannerView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/reviewDialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...