Port FloatingBannerView and ReviewReplyDraftBannerView to spina.

Review Request #12810 — Created Jan. 26, 2023 and submitted — Latest diff uploaded

Information

Review Board
release-6.x

Reviewers

In order to be able to subclass the FloatingBannerView for the new
unified banner, we first need to update it to use TypeScript and spina.
This also required updating the ReviewReplyDraftBannerView to match.

  • Verified that review reply banners worked correctly.
  • Ran js-tests.

Diff Revision 3 (Latest)

orig
1
2
3

Commits

First Last Summary ID Author
Port FloatingBannerView and ReviewReplyDraftBannerView to spina.
In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.
4d080dde93dea99d9f29c6216540fb3dda846ae2 David Trowbridge
reviewboard/staticbundles.py
reviewboard/static/rb/js/reviewRequestPage/index.ts
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js
reviewboard/static/rb/js/ui/index.ts
reviewboard/static/rb/js/views/floatingBannerView.es6.js
Loading...