Summary

Port FloatingBannerView and ReviewReplyDraftBannerView to spina.

Review Request #12810 — Created Jan. 26, 2023 and submitted Feb. 27, 2023, 8:28 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-6.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

In order to be able to subclass the FloatingBannerView for the new
unified banner, we first need to update it to use TypeScript and spina.
This also required updating the ReviewReplyDraftBannerView to match.

Testing Done


Verified that review reply banners worked correctly.
Ran js-tests.

Commits

Summary	ID
Port FloatingBannerView and ReviewReplyDraftBannerView to spina. In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.	4d080dde93dea99d9f29c6216540fb3dda846ae2

Issues

Description	From	Last Updated
Space before {	chipx86	Feb. 3, 2023, 12:39 p.m.
This can use modelEvents: modelEvents = { 'saving destroying': ..., 'saved': ..., 'publishError': ..., }; Works just like events, so …	chipx86	Feb. 3, 2023, 12:40 p.m.
Do we want to maybe move general UI stuff into a RB.UI namespace?	chipx86	Feb. 3, 2023, 12:40 p.m.

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Port FloatingBannerView and ReviewReplyDraftBannerView to spina. In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.	4e7e9bc4ec8cd52d3099707ea23eb1b142a765de
	Port FloatingBannerView and ReviewReplyDraftBannerView to spina. In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.	053a43628375b098b7af35b9c725842d54934f2c

Diff:

Revision 2 (+410 -272)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviewRequestPage/index.ts
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/views/floatingBannerView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts (Diff revision 2)
The issue has been resolved. Show all issues
```
Space before {
```

reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts (Diff revision 2)

The issue has been resolved. Show all issues

This can use modelEvents:

modelEvents = {
    'saving destroying': ...,
    'saved': ...,
    'publishError': ...,
};


Works just like events, so it should be mappable to a function or to a () => ... if you want.

reviewboard/static/rb/js/ui/index.ts (Diff revision 2)

The issue has been dropped. Show all issues

Do we want to maybe move general UI stuff into a RB.UI namespace?

david Feb. 2, 2023, 5:05 p.m.

I was thinking about that, but we theoretically need to maintain compatibility with third parties who might rely on the existing RB.X names. I guess we could alias them?

Change Summary:

Made requested changes.

Commits:

	Summary	ID
	Port FloatingBannerView and ReviewReplyDraftBannerView to spina. In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.	053a43628375b098b7af35b9c725842d54934f2c
	Port FloatingBannerView and ReviewReplyDraftBannerView to spina. In order to be able to subclass the FloatingBannerView for the new unified banner, we first need to update it to use TypeScript and spina. This also required updating the ReviewReplyDraftBannerView to match. Testing Done: - Verified that review reply banners worked correctly. - Ran js-tests.	4d080dde93dea99d9f29c6216540fb3dda846ae2

Diff:

Revision 3 (+406 -272)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviewRequestPage/index.ts
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.ts
	reviewboard/static/rb/js/reviewRequestPage/views/reviewReplyDraftBannerView.es6.js
	reviewboard/static/rb/js/ui/index.ts
	reviewboard/static/rb/js/views/floatingBannerView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-6.x (2a2ae06)