Port FloatingBannerView and ReviewReplyDraftBannerView to spina.
Review Request #12810 — Created Jan. 26, 2023 and submitted
In order to be able to subclass the FloatingBannerView for the new
unified banner, we first need to update it to use TypeScript and spina.
This also required updating the ReviewReplyDraftBannerView to match.
- Verified that review reply banners worked correctly.
- Ran js-tests.
Summary | ID |
---|---|
4d080dde93dea99d9f29c6216540fb3dda846ae2 |
- Commits:
-
Summary ID 4e7e9bc4ec8cd52d3099707ea23eb1b142a765de 053a43628375b098b7af35b9c725842d54934f2c - Diff:
-
Revision 2 (+410 -272)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Change Summary:
-
Made requested changes.
- Commits:
-
Summary ID 053a43628375b098b7af35b9c725842d54934f2c 4d080dde93dea99d9f29c6216540fb3dda846ae2 - Diff:
-
Revision 3 (+406 -272)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.