flake8
passed.
JSHint
passed.
Review Request #12700 — Created Oct. 27, 2022 and submitted
We had a couple places when updating review request counters where we'd
fetch avalues_list
of PKs, and then pass that directly into future
queries, which would end up evaluating them as subqueries. This has two
problems--first, we end up running the subqueries multiple times, and
second, it's impossible to useassertQueries
.This change fixes those up. There are still cases where we have
subqueries that are added by Django'sQuerySet.update()
method, but
this handles the stuff in our own code.
Verified with
assertQueries
usage that we no longer had subqueries for
these.
Summary | ID |
---|---|
8a471f5f26419dd5f7d7be638a1d35ece948d9f9 |