• 
      

    Fix a crash when localizing an authentication error for GitLab.

    Review Request #12678 — Created Oct. 10, 2022 and submitted

    Information

    Review Board
    release-5.0.x

    Reviewers

    When attempting to provide an error message for failed authentication for
    HTTP HEAD requests, ugettext() was used to localize the string. The
    module had been updated to import gettext instead of ugettext, causing
    this to crash.

    This change updates the call to use gettext() instead.

    Added a unit test, which I verified failed before this fix and passed
    after.

    Summary ID
    Fix a crash when localizing an authentication error for GitLab.
    When attempting to provide an error message for failed authentication, `ugettext()` was used to localize the string. The module had been updated to import `gettext` instead of `ugettext`, causing this to crash. This change updates the call to use `gettext()` instead.
    ca0ffaacbbe30393a6b33a86abc8fa71837d379d
    maubin
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-5.0.x (ef0004f)