Fix incorrect check in custom client certificate loading.

 






 

 


  Review Request #12671
  —
  Created Oct. 6, 2022 and submitted 

 




















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  release-4.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
The API implementation has the ability to load a custom client

certificate, but there was a small bug in this. The actual loading was

gated off by checking if either the cert or the key were available, but

we in fact need both. Changing an or to and fixes this.

 








  


 
 

  
Ran unit tests.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix incorrect check in custom client certificate loading.
      
The API implementation has the ability to load a custom client
certificate, but there was a small bug in this. The actual loading was
gated off by checking if either the cert or the key were available, but
we in fact need both. Changing an `or` to `and` fixes this.

Testing Done:
Ran unit tests.

     


    		
    ff1e7e2c61733a237da89079cc9703bb825f74cf

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




chipx86




   

   







  

 



 

  


   

   

    
 
chipx86


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




david




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-4.x (a868a1a)