Make the expiration controls on the API tokens config page nicer.

Review Request #12670 — Created Oct. 5, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This change offers several improvements to the expiration controls on the
API tokens config page:
- Users can edit the expiration of expired tokens.
- Users can set the specific time of the expiration.
- Users can set the expiration to a past date/time.

With this, the API tokens config page offers the same flexibility for editing
expiration dates as the API.

This change also resets the expired_notification_sent flag in a token's
extra_data field whenever a token's expiration is updated, so that users can
get notified again if they set a new expiration date on already expired tokens.

  • Ran JS unit tests.
  • Ran ./reviewboard/webapi/tests/test_api_token.py
  • Manually tested the expiration controls with various combinations of
    starting states, ending states, and with the other controls on the page.

Changes between revision 5 and 6

orig
1
2
3
4
5
6

Commits

Summary ID Author
Improve expiration date and time controls on the API tokens config page.
b1ea6efb68b7bf734d33ee355728f05bcb0c32d3 Michelle Aubin
Improve expiration date and time controls on the API tokens config page.
2856e1c74e0a25cd93dc0069a30a72d7da6123a9 Michelle Aubin
reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js
Loading...