Make the expiration controls on the API tokens config page nicer.

Review Request #12670 — Created Oct. 5, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This change offers several improvements to the expiration controls on the
API tokens config page:
- Users can edit the expiration of expired tokens.
- Users can set the specific time of the expiration.
- Users can set the expiration to a past date/time.

With this, the API tokens config page offers the same flexibility for editing
expiration dates as the API.

This change also resets the expired_notification_sent flag in a token's
extra_data field whenever a token's expiration is updated, so that users can
get notified again if they set a new expiration date on already expired tokens.

  • Ran JS unit tests.
  • Ran ./reviewboard/webapi/tests/test_api_token.py
  • Manually tested the expiration controls with various combinations of
    starting states, ending states, and with the other controls on the page.

Changes between revision 2 and 3

orig
1
2
3
4
5
6

Commits

Summary ID Author
Allow users to edit expiration date ofexpired tokens from the API tokens conf...
c5f65d0ad0f340f6dc8561996dcf35292124c256 Michelle Aubin
Make the expiration date controls on the API tokens config page nicer.
372e509e042577e45689b2cd0de79b4cd22299bb Michelle Aubin
Allow users to edit expiration date ofexpired tokens from the API tokens conf...
b7b24f02fc942f1c2e1ae5f17d7bf7075e43eb95 Michelle Aubin
Make the expiration date controls on the API tokens config page nicer.
52f52ecda4660ca099a83ea97bf2ff1fbd7d4676 Michelle Aubin
reviewboard/static/rb/js/accountPrefsPage/views/apiTokensView.es6.js
reviewboard/webapi/resources/api_token.py
Loading...