• 
      

    Update client tests to enable diff checks and require opting in to diff.

    Review Request #12613 — Created Sept. 20, 2022 and submitted — Latest diff uploaded

    Information

    RBTools
    release-4.x

    Reviewers

    build_client() now accepts a needs_diff= argument, indicating if the
    test needs to perform diff functionality.

    By default, this is False, and attempting to call diff() will result
    in an error.

    By setting to True, diff tool calculations will be performed and
    cached, preventing the tests from having to account for any diff checks
    in any spies. A missing compatible tool will cause the test to be
    skipped.

    Unit tests pass.

    Tested with a client failing a diff tool check. Saw the test was skipped.

    Commits

    Files