Summary

Fix up spacing for ListEditWidget instances.

Review Request #12595 — Created Sept. 13, 2022 and submitted Sept. 15, 2022, 1:31 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The list edit widget that we use for some complex form fields didn't
have proper spacing, ending up with everything all smushed together.
This change adds some margins so that things look nice(r).

Testing Done

Looked at the diffviewer settings and OAuth application form where we
use this widget in a couple different ways. Saw that things looked nicer
now.

Commits

Summary	ID
Fix up spacing for ListEditWidget instances. The list edit widget that we use for some complex form fields didn't have proper spacing, ending up with everything all smushed together. This change adds some margins so that things look nice(r). Testing Done: Looked at the diffviewer settings and OAuth application form where we use this widget in a couple different ways. Saw that things looked nicer now.	36a4a0387f0b9814e2076d162a8da927968a783c

Summary

Fix up spacing for ListEditWidget instances.

The list edit widget that we use for some complex form fields didn't have proper spacing, ending up with everything all smushed together. This change adds some margins so that things look nice(r). Testing Done: Looked at the diffviewer settings and OAuth application form where we use this widget in a couple different ways. Saw that things looked nicer now.

36a4a0387f0b9814e2076d162a8da927968a783c

Files

Issues

Description	From	Last Updated
Can we use an em measurement? 0.5em or 1em?	chipx86	Sept. 13, 2022, 1:02 p.m.

flake8 passed.

JSHint passed.

djblets/static/djblets/css/forms/list_edit.less (Diff revision 1)
The issue has been resolved. Show all issues
```
Can we use an em measurement? 0.5em or 1em?
```

Commits:

	Summary	ID
	Fix up spacing for ListEditWidget instances. The list edit widget that we use for some complex form fields didn't have proper spacing, ending up with everything all smushed together. This change adds some margins so that things look nice(r). Testing Done: Looked at the diffviewer settings and OAuth application form where we use this widget in a couple different ways. Saw that things looked nicer now.	52f18e3ff1ab7511027cc1301eaf58903d6402bf
	Fix up spacing for ListEditWidget instances. The list edit widget that we use for some complex form fields didn't have proper spacing, ending up with everything all smushed together. This change adds some margins so that things look nice(r). Testing Done: Looked at the diffviewer settings and OAuth application form where we use this widget in a couple different ways. Saw that things looked nicer now.	36a4a0387f0b9814e2076d162a8da927968a783c

Diff:

Revision 2 (+4)

Show changes

djblets/static/djblets/css/forms/list_edit.less

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Lookin' good, thanks for adding that!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (f86a6be)