Update diff functions on all SCMClients and remove client-specific args.

Review Request #12584 — Created Sept. 7, 2022 and submitted — Latest diff uploaded

Information

RBTools
release-4.x

Reviewers

We had a lot of inconsistency between diff() function signatures in
SCMClients. Some took only a subset of the arguments. Some took
arguments not defined in BaseSCMClient.diff(). Git had its own
Git-specific argument, --git-find-renames-threshold.

This updates all function signatures to be compatible with the base
function signature.

The Git-specific option has been removed. Instead, GitClient.diff()
now just checks self.options, instead of rbt post and rbt diff
doing this.

Unit tests pass.

Tested rbt diff and rbt post with --git-find-renames-threshold.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Update diff functions on all SCMClients and remove client-specific args.
We had a lot of inconsistency between `diff()` function signatures in SCMClients. Some took only a subset of the arguments. Some took arguments not defined in `BaseSCMClient.diff()`. Git had its own Git-specific argument, `git_find_renames_threshold`. This updates all function signatures to be compatible with the base function signature. The Git-specific option has been removed. Instead, `GitClient.diff()` now just checks `self.options`, instead of `rbt post` and `rbt diff` doing this.
453434e2516e851255b3814f1eadced3fb886776 Christian Hammond
rbtools/clients/clearcase.py
rbtools/clients/git.py
rbtools/clients/mercurial.py
rbtools/clients/perforce.py
rbtools/clients/plastic.py
rbtools/clients/sos.py
rbtools/clients/svn.py
rbtools/clients/tfs.py
rbtools/clients/base/scmclient.py
rbtools/commands/diff.py
rbtools/commands/post.py
Loading...