Fix setting the default token generator via Djblets.

 






 

 


  Review Request #12582
  —
  Created Sept. 6, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
The default token generator can be set via 

settings.DJBLETS_DEFAULT_API_TOKEN_GENERATOR but this currently takes a class,

which isn't safe to import via settings.py. With this change we instead accept

a token generator ID, which is safe and ensures that we're only using token

generators that are registered.

 








  


 
 

  
    

  • Created new unit tests for getting the default token generator.
    • 

  • Ran unit tests in djblets.secrets.tests.
    • 

  • Ran unit tests in reviewboard.webapi.tests.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Fix setting the default token generator via Djblets.

   
  		
  ccbae85d590328de4b6a2474f0278958b4f8c2cb
  Michelle Aubin
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/secrets/tests/test_token_generator_registry.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/secrets/token_generators/registry.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...