Update Bazaar for run_process and better type safety.
Review Request #12573 — Created Aug. 25, 2022 and submitted
BazaarClient
has been updated to use the newrun_process()
instead
ofexecute()
, providing better type safety and results, with more
thorough unit testing.The functions in
BazaarClient
have also been updated to have type
annotations. This has already caught a few places where we made
assumptions about values that led to bad command invocations.Some of this code now asserts the values that are being worked, to
ensure they're notNone
or the wrong type.There's further work that may need to be done here.
parse_revision_spec()
can fill inNone
values, which will now
trigger some later assertions, but we should probably raise exceptions
here. A TODO has been left inparse_revision_spec()
to track this.
Unit tests pass on Python 3.7-3.11.
Summary | ID |
---|---|
2a0f40f62f5daa51f53d662eb86b5600e953cc38 |