Summary

Ensure usage of modern packages when using 'setup.py develop'.

Review Request #12524 — Created Aug. 14, 2022 and submitted Aug. 15, 2022, 8:15 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-4.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The Python packaging world has long since recommended against eggs and
setup.py develop. However, until we move to a pyproject.toml with
a custom build system, this is our best option.

Review Board, Djblets, and other packages have implemented a custom
setup.py develop for ages, which wraps pip install -e . (the
generally preferred method) and then installs our development
dependencies.

This change adds the same logic to the RBTools packaging. This will
ensure that we don't ever introduce legacy eggs through RBTools for
development, and always prefer model wheels.

For now, setup.py develop is the preferred way of preparing RBTools
for development. In time, we will transition away from setup.py and
will prefer pip install -e ..

Testing Done

Successfully installed RBTools on Python 3.7-3.11, with all dependencies
as wheels, using setup.py develop.

Commits

Summary	ID
Ensure usage of modern packages when using 'setup.py develop'. The Python packaging world has long since recommended against eggs and `setup.py develop`. However, until we move to a `pyproject.toml` with a custom build system, this is our best option. Review Board, Djblets, and other packages have implemented a custom `setup.py develop` for ages, which wraps `pip install -e .` (the generally preferred method) and then installs our development dependencies. This change adds the same logic to the RBTools packaging. This will ensure that we don't ever introduce legacy eggs through RBTools for development, and always prefer model wheels. For now, `setup.py develop` is the preferred way of preparing RBTools for development. In time, we will transition away from `setup.py` and will prefer `pip install -e .`.	c7c8d2529c6944819fc5f6dc1c690ca3b77b92c6

Summary

Ensure usage of modern packages when using 'setup.py develop'.

The Python packaging world has long since recommended against eggs and `setup.py develop`. However, until we move to a `pyproject.toml` with a custom build system, this is our best option. Review Board, Djblets, and other packages have implemented a custom `setup.py develop` for ages, which wraps `pip install -e .` (the generally preferred method) and then installs our development dependencies. This change adds the same logic to the RBTools packaging. This will ensure that we don't ever introduce legacy eggs through RBTools for development, and always prefer model wheels. For now, `setup.py develop` is the preferred way of preparing RBTools for development. In time, we will transition away from `setup.py` and will prefer `pip install -e .`.

c7c8d2529c6944819fc5f6dc1c690ca3b77b92c6

Issues

Description	From	Last Updated
too many blank lines (2) Column: 5 Error code: E303	reviewbot	Aug. 14, 2022, 9:17 p.m.

flake8 failed.

JSHint passed.

flake8

setup.py (Diff revision 1)
The issue has been resolved. Show all issues
```
too many blank lines (2)

Column: 5
Error code: E303
```

Change Summary:

Removed an extra blank line.

Commits:

	Summary	ID
	Ensure usage of modern packages when using 'setup.py develop'. The Python packaging world has long since recommended against eggs and `setup.py develop`. However, until we move to a `pyproject.toml` with a custom build system, this is our best option. Review Board, Djblets, and other packages have implemented a custom `setup.py develop` for ages, which wraps `pip install -e .` (the generally preferred method) and then installs our development dependencies. This change adds the same logic to the RBTools packaging. This will ensure that we don't ever introduce legacy eggs through RBTools for development, and always prefer model wheels. For now, `setup.py develop` is the preferred way of preparing RBTools for development. In time, we will transition away from `setup.py` and will prefer `pip install -e .`.	3d5ca23c19b991cf4128686bbc36e1678c5ee42e
	Ensure usage of modern packages when using 'setup.py develop'. The Python packaging world has long since recommended against eggs and `setup.py develop`. However, until we move to a `pyproject.toml` with a custom build system, this is our best option. Review Board, Djblets, and other packages have implemented a custom `setup.py develop` for ages, which wraps `pip install -e .` (the generally preferred method) and then installs our development dependencies. This change adds the same logic to the RBTools packaging. This will ensure that we don't ever introduce legacy eggs through RBTools for development, and always prefer model wheels. For now, `setup.py develop` is the preferred way of preparing RBTools for development. In time, we will transition away from `setup.py` and will prefer `pip install -e .`.	c7c8d2529c6944819fc5f6dc1c690ca3b77b92c6

Diff:

Revision 2 (+140)

Show changes

setup.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.x (dcc3686)

setup.py (Diff revision 1)