Move base rbtools.clients support into rbtools.clients.base.

Review Request #12518 — Created Aug. 9, 2022 and submitted — Latest diff uploaded

Information

RBTools
release-4.x

Reviewers

We have a lot of support code in rbtools.clients.__init__, with more
coming. This has been hard to maintain, and was going to create some
circular dependency issues.

This cleanup has been long-overdue. This change moves SCMClient,
RepositoryInfo, PatchAuthor, and PatchResult into sub-modules of
rbtools.clients.base.

In the process, SCMClient has been renamed to BaseSCMClient, to
better fit modern naming of base classes.

There is a legacy SCMClient class in rbtools.clients that emits a
deprecation warning when instantiated. It will be removed in 5.0.

Aside from that, all the changes are mechanical or updates to references
in documentation.

All unit tests pass.

Posted this change using this build.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Move base rbtools.clients support into rbtools.clients.base.
We have a lot of support code in `rbtools.clients.__init__`, with more coming. This has been hard to maintain, and was going to create some circular dependency issues. This cleanup has been long-overdue. This change moves `SCMClient`, `RepositoryInfo`, `PatchAuthor`, and `PatchResult` into sub-modules of `rbtools.clients.base`. In the process, `SCMClient` has been renamed to `BaseSCMClient`, to better fit modern naming of base classes. There is a legacy `SCMClient` class in `rbtools.clients` that emits a deprecation warning when instantiated. It will be removed in 5.0. Aside from that, all the changes are mechanical or updates to references in documentation.
61e0001eda8f47fc0b98abda79f8d8227469fb42 Christian Hammond
rbtools/clients/__init__.py
rbtools/clients/bazaar.py
rbtools/clients/clearcase.py
rbtools/clients/cvs.py
rbtools/clients/git.py
rbtools/clients/mercurial.py
rbtools/clients/perforce.py
rbtools/clients/plastic.py
rbtools/clients/sos.py
rbtools/clients/svn.py
rbtools/clients/tfs.py
rbtools/clients/base/patch.py
rbtools/clients/base/repository.py
rbtools/clients/base/scmclient.py
rbtools/clients/tests/__init__.py
rbtools/commands/__init__.py
rbtools/testing/commands.py
rbtools/utils/repository.py
rbtools/utils/review_request.py
rbtools/utils/tests/test_review_request.py
Loading...