Move base rbtools.clients support into rbtools.clients.base.
Review Request #12518 — Created Aug. 9, 2022 and submitted
We have a lot of support code in
rbtools.clients.__init__
, with more
coming. This has been hard to maintain, and was going to create some
circular dependency issues.This cleanup has been long-overdue. This change moves
SCMClient
,
RepositoryInfo
,PatchAuthor
, andPatchResult
into sub-modules of
rbtools.clients.base
.In the process,
SCMClient
has been renamed toBaseSCMClient
, to
better fit modern naming of base classes.There is a legacy
SCMClient
class inrbtools.clients
that emits a
deprecation warning when instantiated. It will be removed in 5.0.Aside from that, all the changes are mechanical or updates to references
in documentation.
All unit tests pass.
Posted this change using this build.
Summary | ID |
---|---|
05e95e31749b26d95d991c6068a071b7f8b38893 |
- Change Summary:
-
Updated to target RBTools 4.0.
- Description:
-
We have a lot of support code in
rbtools.clients.__init__
, with morecoming. This has been hard to maintain, and was going to create some circular dependency issues. This cleanup has been long-overdue. This change moves
SCMClient
,RepositoryInfo
,PatchAuthor
, andPatchResult
into sub-modules ofrbtools.clients.base
.In the process,
SCMClient
has been renamed toBaseSCMClient
, tobetter fit modern naming of base classes. There is a legacy
SCMClient
class inrbtools.clients
that emits a~ deprecation warning when instantiated. It will be removed in 4.0. ~ deprecation warning when instantiated. It will be removed in 5.0. Aside from that, all the changes are mechanical or updates to references
in documentation. - Commits:
-
Summary ID 26cdab0784482f038e50ee08706132d55811c750 61e0001eda8f47fc0b98abda79f8d8227469fb42 - Branch:
-
release-3.xrelease-4.x