Fix the GoTool unit tests to not be sensitive to elapsed time.

 






 

 


  Review Request #12490
  —
  Created July 27, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  ReviewBot
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewbot
 









 
 

  
 






 








 





  


 
 

  
One of the GoTool unit tests compares a result containing text showing

the number of seconds elapsed for a check. While often 0.00s, this

would sometimes break CI, particularly when there were a lot of builds

happening simultaneously.


This switches the test to compare via a regex, giving us more

flexibility.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix the GoTool unit tests to not be sensitive to elapsed time.
     
One of the GoTool unit tests compares a result containing text showing
the number of seconds elapsed for a check. While often `0.00s`, this
would sometimes break CI, particularly when there were a lot of builds
happening simultaneously.

This switches the test to compare via a regex, giving us more
flexibility.

    

   
  		
  8da7c021c872da4f35e956c6e6f39632b56ffecb
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      bot/reviewbot/tools/tests/test_gotool.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...