Modernize code in rbintegratons.
Review Request #12483 — Created July 21, 2022 and submitted — Latest diff uploaded
When we updated rbintegrations to work with Review Board 5.0, we only
really did the minimum required to make things work. Because
rbintegrations 3.0+ will only be used with Review Board 5.0+ / Django
3.2+ / Python 3.7+, we can do a lot more. This change updates the
codebase to handle some additional modernization tasks:
- Remove
__future__
imports. - Switch from
django.conf.urls
todjango.urls
and swap outurl()
for
the newpath()
. - Move from
ugettext
togettext
. - Eliminate fallback imports and conditional logic for handling various
versions of Review Board.
- Ran unit tests.
- Did some superficial testing setting up various integration
configurations.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
rbintegrations/idonethis/forms.py |
---|
rbintegrations/idonethis/integration.py |
---|
rbintegrations/idonethis/pages.py |
---|
rbintegrations/idonethis/tests.py |
---|
rbintegrations/idonethis/utils.py |
---|
rbintegrations/jenkinsci/api.py |
---|
rbintegrations/jenkinsci/common.py |
---|
rbintegrations/jenkinsci/forms.py |
---|
rbintegrations/jenkinsci/integration.py |
---|
rbintegrations/jenkinsci/tests.py |
---|
rbintegrations/matrix/forms.py |
---|
rbintegrations/matrix/integration.py |
---|
rbintegrations/matrix/tests.py |
---|
rbintegrations/mattermost/integration.py |
---|
rbintegrations/mattermost/tests.py |
---|
rbintegrations/slack/integration.py |
---|
rbintegrations/slack/tests.py |
---|
rbintegrations/testing/testcases.py |
---|
rbintegrations/travisci/api.py |
---|
rbintegrations/travisci/forms.py |
---|