Modernize code in rbintegratons.

Review Request #12483 — Created July 21, 2022 and submitted — Latest diff uploaded

Information

rbintegrations
release-3.x

Reviewers

When we updated rbintegrations to work with Review Board 5.0, we only
really did the minimum required to make things work. Because
rbintegrations 3.0+ will only be used with Review Board 5.0+ / Django
3.2+ / Python 3.7+, we can do a lot more. This change updates the
codebase to handle some additional modernization tasks:

  • Remove __future__ imports.
  • Switch from django.conf.urls to django.urls and swap out url() for
    the new path().
  • Move from ugettext to gettext.
  • Eliminate fallback imports and conditional logic for handling various
    versions of Review Board.
  • Ran unit tests.
  • Did some superficial testing setting up various integration
    configurations.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

orig
1
2
3

Commits

First Last Summary ID Author
Modernize code in rbintegratons.
When we updated rbintegrations to work with Review Board 5.0, we only really did the minimum required to make things work. Because rbintegrations 3.0+ will only be used with Review Board 5.0+ / Django 3.2+ / Python 3.7+, we can do a lot more. This change updates the codebase to handle some additional modernization tasks: - Remove `__future__` imports. - Switch from `django.conf.urls` to `django.urls` and swap out `url()` for the new `path()`. - Move from `ugettext` to `gettext`. - Eliminate fallback imports and conditional logic for handling various versions of Review Board. Testing Done: - Ran unit tests. - Did some superficial testing setting up various integration configurations.
ca3655f9565157fe8f15229b2210e72e549da34b David Trowbridge
This diff has been split across 3 pages: 1 2 3 >
docs/releasenotes/conf.py
docs/releasenotes/_ext/extralinks.py
rbintegrations/__init__.py
rbintegrations/extension.py
rbintegrations/asana/fields.py
rbintegrations/asana/forms.py
rbintegrations/asana/integration.py
rbintegrations/asana/tests.py
rbintegrations/asana/urls.py
rbintegrations/asana/views.py
rbintegrations/basechat/forms.py
rbintegrations/basechat/integration.py
rbintegrations/circleci/forms.py
rbintegrations/circleci/integration.py
rbintegrations/circleci/tests.py
rbintegrations/circleci/urls.py
rbintegrations/circleci/views.py
rbintegrations/discord/forms.py
rbintegrations/discord/integration.py
rbintegrations/discord/tests.py
This diff has been split across 3 pages: 1 2 3 >
Loading...