• 
      

    Fix issues running unit tests with newer RBTools and with writable root.

    Review Request #12460 — Created July 11, 2022 and submitted

    Information

    ReviewBot
    release-3.x

    Reviewers

    Recent RBTools 3.x releases updated API error messages to be a bit more
    useful. This broke a couple unit tests that checked for the resulting
    error message.

    These tests have been updated to check the current strings, and
    dev-requirements.txt has been updated to specifically require the
    newer versions.

    We had a couple other unit tests that checked for issues writing a
    cookie file. They attempted to point to a directory off of / that it
    couldn't write to. This assumed the tests were being run in an
    environment without a writable /, but that's not the case in CI
    environments.

    These tests now base their paths off of /dev/null, which should convey
    the same sort of error.

    Unit tests pass with the newer RBTools.

    Attempted to simulate the writable root test in a CI environment. The
    real test will happen after this has landed.

    Summary ID
    Fix issues running unit tests with newer RBTools and with writable root.
    Recent RBTools 3.x releases updated API error messages to be a bit more useful. This broke a couple unit tests that checked for the resulting error message. These tests have been updated to check the current strings, and `dev-requirements.txt` has been updated to specifically require the newer versions. We had a couple other unit tests that checked for issues writing a cookie file. They attempted to point to a directory off of `/` that it couldn't write to. This assumed the tests were being run in an environment without a writable `/`, but that's not the case in CI environments. These tests now base their paths off of `/dev/null`, which should convey the same sort of error.
    8245fd0e27b66006ce822b6999a9355318b2d685
    maubin
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (c5bcbde)