Fix Review Bot extension unit tests on Review Board 3.

 






 

 


  Review Request #12454
  —
  Created July 11, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  ReviewBot
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewbot
 









 
 

  
 






 








 





  


 
 

  
The unit tests for Review Bot were unconditionally importing reverse

from the modern django.urls, which wasn't available on Django 1.6 /

Review Board 3.


They're now updated to fall back on the older import from

django.core.urlresolvers, allowing tests to run on Review Board 3.

 








  


 
 

  
Unit tests pass on Review Board 3, 4, and 5.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix Review Bot extension unit tests on Review Board 3.
     
The unit tests for Review Bot were unconditionally importing `reverse`
from the modern `django.urls`, which wasn't available on Django 1.6 /
Review Board 3.

They're now updated to fall back on the older import from
`django.core.urlresolvers`, allowing tests to run on Review Board 3.

    

   
  		
  4decbbe62796cd007f4947aeeed67c0936b0d970
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      extension/reviewbotext/tests/test_worker_status_view.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...