Fix unit test regressions in the Review Bot extension and ease testing.

Review Request #12451 — Created July 11, 2022 and submitted — Latest diff uploaded

Information

ReviewBot
release-3.x

Reviewers

The recent change to fix stale broker connections failed to actually
store the revised broker URL used to help indicate if a connection was
stale. This led to creating a brand-new Celery connection every time the
property was accessed, and broke unit tests in the process.

This change fixes that, and also improves test infrastructure by
supplying a default settings_local.py file that can be used. This
avoids needing to have one already set up in a dev server in order to
run tests.

Unit tests pass, without a settings_local.py being in the Python path.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix unit test regressions in the Review Bot extension and ease testing.
The recent change to fix stale broker connections failed to actually store the revised broker URL used to help indicate if a connection was stale. This led to creating a brand-new Celery connection every time the property was accessed, and broke unit tests in the process. This change fixes that, and also improves test infrastructure by supplying a default `settings_local.py` file that can be used. This avoids needing to have one already set up in a dev server in order to run tests.
72576834d116b87c1218ee24ed4b41c0c9c35a56 Christian Hammond
extension/reviewbotext/extension.py
extension/tests/runtests.py
extension/tests/settings_local.py
Loading...