Summary

Kick the deprecation can down the road.

Review Request #12448 — Created July 8, 2022 and submitted July 11, 2022, 2:53 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Several of our auxiliary packages were still using functionality that
was supposed to be removed for Review Board 5.0. Given how much churn
we've already had, trying to fix these up on an emergency basis doesn't
seem wise. This change switches out all the
RemovedInReviewBoard50Warning uses for
RemovedInReviewBoard60Warning.

Testing Done

Ran unit tests.

Commits

Summary	ID
Kick the deprecation can down the road. Several of our auxiliary packages were still using functionality that was supposed to be removed for Review Board 5.0. Given how much churn we've already had, trying to fix these up on an emergency basis doesn't seem wise. This change switches out all the `RemovedInReviewBoard50Warning` uses for `RemovedInReviewBoard60Warning`. Testing Done: Ran unit tests.	6c8807a21d4975cfe1c1cdc81c884e24a5f35587

Summary

Kick the deprecation can down the road.

Several of our auxiliary packages were still using functionality that was supposed to be removed for Review Board 5.0. Given how much churn we've already had, trying to fix these up on an emergency basis doesn't seem wise. This change switches out all the `RemovedInReviewBoard50Warning` uses for `RemovedInReviewBoard60Warning`. Testing Done: Ran unit tests.

6c8807a21d4975cfe1c1cdc81c884e24a5f35587

Issues

Description	From	Last Updated
Text should be updated to say 6.0. Same with most other strings.	chipx86	July 10, 2022, 2:04 p.m.

flake8 passed.

JSHint passed.

reviewboard/admin/checks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Text should be updated to say 6.0.
Same with most other strings.
```

Commits:

	Summary	ID
	Kick the deprecation can down the road. Several of our auxiliary packages were still using functionality that was supposed to be removed for Review Board 5.0. Given how much churn we've already had, trying to fix these up on an emergency basis doesn't seem wise. This change switches out all the `RemovedInReviewBoard50Warning` uses for `RemovedInReviewBoard60Warning`. Testing Done: Ran unit tests.	4b404ca5597c9719d7f584f484611b94fe2475a8
	Kick the deprecation can down the road. Several of our auxiliary packages were still using functionality that was supposed to be removed for Review Board 5.0. Given how much churn we've already had, trying to fix these up on an emergency basis doesn't seem wise. This change switches out all the `RemovedInReviewBoard50Warning` uses for `RemovedInReviewBoard60Warning`. Testing Done: Ran unit tests.	6c8807a21d4975cfe1c1cdc81c884e24a5f35587

Diff:

Revision 2 (+110 -132)

Show changes

	reviewboard/deprecation.py
	reviewboard/admin/checks.py
	reviewboard/admin/widgets.py
	reviewboard/admin/forms/search_settings.py
	reviewboard/admin/tests/test_search_settings_form.py
	reviewboard/diffviewer/diffutils.py
	reviewboard/diffviewer/parser.py
	reviewboard/diffviewer/tests/test_diff_parser.py
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (75b66cf)

reviewboard/admin/checks.py (Diff revision 1)