Fix URL template for password reset confirmation.

Review Request #12422 — Created June 28, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

When I was updating the URLs, I kept the regex that we were previously
using for the password_reset_confirm URL. Unfortunately, it looks like
Django has updated their token generation to create tokens that are
longer than the 20 characters that our old URL handled, resulting in a
NoReverseMatch. The upstream URLs inside the django.contrib.auth app
now just use reset/<uidb64>/<token>/, so I've updated ours to match.

Went through the password reset process and saw that I didn't get URL
lookup errors anymore.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Fix URL template for password reset confirmation.
When I was updating the URLs, I kept the regex that we were previously using for the `password_reset_confirm` URL. Unfortunately, it looks like Django has updated their token generation to create tokens that are longer than the 20 characters that our old URL handled, resulting in a `NoReverseMatch`. The upstream URLs inside the `django.contrib.auth` app now just use `reset/<uidb64>/<token>/`, so I've updated ours to match. Testing Done: Went through the password reset process and saw that I didn't get URL lookup errors anymore.
e21ca04d6de8de382a453dda2ab2b5f855cc9e1d David Trowbridge
reviewboard/accounts/urls.py
Loading...